Add GitHub Actions workflow for COBOL compilation checks#59
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
Add GitHub Actions workflow for COBOL compilation checks#59devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: Roshan Fernando <roshandean4@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Roshan Fernando <roshandean4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GitHub Actions workflow for COBOL compilation checks
Summary
Adds CI to verify that COBOL examples still compile. The workflow (
.github/workflows/compile-check.yml) triggers on push/PR tomainand does two things:cobc -fsyntax-onlyon all.cblfiles exceptsql/(excluded becauseEXEC SQLblocks require the esqlOC precompiler to parse)json_generate,xml_generate,numval_test,comp_test,trim,is_numeric,merge_sort) and verifies they produce executablesSkipped entirely (with documented reasons in the workflow):
sql/— requires esqlOC precompiler and libocsql (not available in CI); excluded from both syntax check and compilationaccept/,mouse/,screen_size/— require interactive terminal input; skipped from compilation but still syntax-checkedAlso adds a CI status badge to the top of
README.md.Updates since last revision
sql/from the syntax-check step as well (not just the compile step). TheEXEC SQLblocks causecobc -fsyntax-onlyto fail without the esqlOC preprocessor. CI now passes.Review & Testing Checklist for Human
display_test,display_timing,read_command_args,report_writer,search,sub_program,unstring,redifinesare currently only syntax-checked, not compiled. Verify this is the desired split — some of these may be safe to add to the compile step.README.mdlinks to the correct workflow and shows a passing status.ubuntu-latest: The workflow usesubuntu-latest(currently Ubuntu 24.04, GnuCOBOL 3.1.2). If the runner image or packaged GnuCOBOL version changes in the future, compilation behavior could change. Pinning toubuntu-24.04may be more stable.Suggested test plan: Merge this PR, then push a trivial commit to
main(or open a test PR) and confirm the workflow runs and passes end-to-end. Verify the badge updates on the README.Notes