chore: upgrade AdvancedSearch.Server (Vue3) to .NET 8.0#17
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
chore: upgrade AdvancedSearch.Server (Vue3) to .NET 8.0#17devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Target framework: net6.0 -> net8.0
- Microsoft.EntityFrameworkCore.Sqlite: 6.0.1 -> 8.0.11
- Microsoft.EntityFrameworkCore.SqlServer: 6.0.1 -> 8.0.11
- Microsoft.AspNetCore.SpaProxy: 6.*-* -> 8.0.11
- Remove Microsoft.AspNetCore.SpaServices.Extensions (removed in .NET 8)
- Add app.UseDefaultFiles() for static file serving
- Add endpoints.MapFallbackToFile("index.html") for SPA routing
Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Vue3 AdvancedSearch.Server project from .NET 6.0 to .NET 8.0.
csproj changes:
net6.0→net8.0Microsoft.EntityFrameworkCore.Sqlite6.0.1 → 8.0.11Microsoft.EntityFrameworkCore.SqlServer6.0.1 → 8.0.11Microsoft.AspNetCore.SpaProxy6.*-* → 8.0.11Microsoft.AspNetCore.SpaServices.Extensions(dropped in .NET 8)Startup.cs changes (to compensate for SpaServices.Extensions removal):
app.UseDefaultFiles()beforeapp.UseStaticFiles()endpoints.MapFallbackToFile("index.html")for SPA client-side routingThird-party packages (Korzh.EasyQuery, EasyData, Korzh.DbUtils, Newtonsoft.Json) were left at their current versions as they target netstandard2.0 and compiled successfully against net8.0.
dotnet buildpasses with 0 errors (61 pre-existing nullable warnings).Review & Testing Checklist for Human
MapFallbackToFile("index.html")doesn't intercept EasyQuery API routes (it shouldn't since fallback only matches when no other endpoint does, but worth confirming with a query request)<PackageReference>line (8 spaces vs 4) — cosmetic onlyNotes
UseSpa()/UseSpaStaticFiles()/UseVueCli()blocks in Startup.cs were already disabled before this change; they were left as-is since they're inert comments.System.Net.Http,System.Data.SqlClient, andSystem.Text.RegularExpressionsare inbox on .NET 8 but were kept since the build succeeds and removing them is a separate cleanup concern.Link to Devin session: https://app.devin.ai/sessions/f8059f78151e454898c9465ce6a1bd53
Requested by: @tobydrinkall