Upgrade Java 6 to Java 11 with Dropwizard 2.1.12#20
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Java 6 to Java 11 with Dropwizard 2.1.12#20devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update Dropwizard BOM from 1.0.5 to 2.1.12 and add dropwizard-dependencies BOM - Update maven-compiler-plugin to 3.13.0 with <release>11</release> - Update maven-surefire-plugin to 3.2.5 - Update maven-shade-plugin to 3.6.0 with module-info.class exclusion - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO.findAll() typing for Hibernate 5 compatibility - Migrate test from JUnit 3 to JUnit 5 Co-Authored-By: Siddhant Seghal <siddxs5@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee application from Java 6 to Java 11, including a major Dropwizard framework upgrade from 1.0.5 to 2.1.12.
Build config (
pom.xml):${project.version}(was 1.0.5) → pinned to2.1.12; addeddropwizard-dependenciesBOM<source>1.6</source>/<target>1.6</target>→<release>11</release>(plugin 3.6.0 → 3.13.0)module-info.classexclusion to prevent conflicts in uber JARSource changes:
EmployeeConfiguration.java:@NotEmptyimport moved fromorg.hibernate.validator.constraints→javax.validation.constraints(old annotation removed in newer Hibernate Validator)EmployeeDAO.java: Added explicit cast ofnamedQuery()result toQuery<Employee>— Dropwizard 2.x'snamedQuery()returnsQuery<?>instead of rawQuery, breaking thelist()callAppTest.java: Migrated from JUnit 3 (TestCase/TestSuite) to JUnit 5 (@Test/Assertions) — JUnit 3 classes are no longer on the classpath with Dropwizard 2.xVerified locally:
mvn clean verifypasses (compile + test + uber JAR) with OpenJDK 11.0.30.Review & Testing Checklist for Human
java -jar target/DropwizardEmployee-1.0.5.jar server example.yml— verify it starts,GET /employeereturns[], andPOST /employeecreates records. The existing test (assertTrue(true)) provides zero functional coverage.EmployeeDAOunchecked cast: The@SuppressWarnings("unchecked")cast fromQuery<?>toQuery<Employee>is a pragmatic fix but suppresses type safety. Confirm the named query executes correctly at runtime.Notes
javax.xml.bind,javax.xml.ws, etc.) were used in the codebase, so no standalone replacements were needed.Link to Devin session: https://app.devin.ai/sessions/177575b9a7c647a59b27a22c9e8cd928
Requested by: @wavecreator1