Upgrade from Java 6 to Java 11#21
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
- Upgrade Dropwizard BOM from 1.0.5 to 2.1.12, add dropwizard-dependencies BOM - Update maven-compiler-plugin to 3.13.0 with <release>11</release> - Update maven-surefire-plugin from 2.19.1 to 3.2.5 - Update maven-shade-plugin from 2.4.3 to 3.6.0 with module-info.class exclusion - Add explicit JUnit 4.13.2 and junit-vintage-engine 5.10.1 for test compatibility - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO.findAll() typing for Hibernate 5.x Query<Employee> compatibility Co-Authored-By: Siddhant Seghal <siddxs5@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
End-to-End Test Results — Java 6 → 11 UpgradeBuilt and ran the upgraded app locally (Dropwizard 2.1.12, Java 11 bytecode on Java 21 runtime). All tests passed. Test Results
Build Validation
CI NotesTwo non-required Snyk checks (security/license) failed — external dependency scans, not blocking merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee application from Java 6 to Java 11, including a major Dropwizard framework bump from 1.0.5 to 2.1.12 and associated dependency/plugin updates.
Build changes (
pom.xml):${project.version}→ pinned to2.1.12; addeddropwizard-dependenciesBOM<source>1.6</source>/<target>1.6</target>→<release>11</release>(plugin 3.6.0 → 3.13.0)module-info.classexclusion for Java 9+ uber-JAR compatibilityjunit:junit:4.13.2+junit-vintage-engine:5.10.1(needed because surefire 3.x uses JUnit Platform, and the existing test extends JUnit 3TestCase)Source changes:
EmployeeConfiguration.java:@NotEmptyimport moved from deprecatedorg.hibernate.validator.constraints→javax.validation.constraintsEmployeeDAO.java: Added unchecked cast ofnamedQuery()result toQuery<Employee>to satisfy Hibernate 5.x/Dropwizard 2.x stricter generics onAbstractDAO.list()Validation:
mvn clean verifypasses — zero compilation errors, 1/1 tests pass.Review & Testing Checklist for Human
java -jar target/DropwizardEmployee-1.0.5.jar server example.ymland verifyPOST /employeeandGET /employeework correctly. The existing test suite is onlyassertTrue(true)— it provides no real coverage of application behavior after this major framework bump.@SuppressWarnings("unchecked")cast on thenamedQuery()result is safe for this specific query but suppresses type-safety checks — verify no other DAO patterns are planned that could be affected.Notes
Link to Devin session: https://app.devin.ai/sessions/6a052d7ee9d343159bbd18af85864bc3
Requested by: @wavecreator1