Upgrade from Java 6 to Java 11#23
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
- Update maven-compiler-plugin to 3.13.0 with <release>11</release> - Decouple Dropwizard BOM from project version; upgrade to Dropwizard 2.1.12 - Add dropwizard-dependencies BOM import - Update maven-surefire-plugin to 3.2.5 - Update maven-shade-plugin to 3.6.0 with module-info.class exclusion - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO: namedQuery() -> namedTypedQuery() for Hibernate 5.x type safety - Migrate test from JUnit 3 to JUnit 5 (Jupiter) Co-Authored-By: Siddhant Seghal <siddxs5@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee project from Java 6 to Java 11, including a major Dropwizard framework upgrade from 1.0.5 to 2.1.12 and all necessary source code fixes.
Build changes (
pom.xml):${project.version}— now pinned to2.1.12dropwizard-dependenciesBOM import for transitive dependency management<source>1.6</source>/<target>1.6</target>→<release>11</release>module-info.classexclusion to shade plugin filters (Java 9+ uber-JAR compatibility)Source code fixes:
EmployeeConfiguration.java:@NotEmptyimport moved fromorg.hibernate.validator.constraints→javax.validation.constraints(deprecated in newer Hibernate Validator)EmployeeDAO.java:namedQuery()→namedTypedQuery()to satisfy Dropwizard 2.x's type-safeAbstractDAO.list(Query<E>)signatureAppTest.java: Migrated from JUnit 3 (junit.framework.*) to JUnit 5 (org.junit.jupiter.api.*)Validation:
mvn clean verifypasses — zero compilation errors, all tests pass.Review & Testing Checklist for Human
java -jar target/DropwizardEmployee-1.0.5.jar server example.ymland confirm the app boots, the/employeeGET and POST endpoints respond correctly, and Hibernate initializes against the H2 database without errors.namedTypedQuerybehavior: Verify thatEmployeeDAO.findAll()returns the correct typed results at runtime — this was changed fromnamedQuery()tonamedTypedQuery()to fix a compilation error with Dropwizard 2.x's stricter generics.Notes
1.0.5— it is now decoupled from the Dropwizard framework version, which was previously tied via${project.version}.Link to Devin session: https://app.devin.ai/sessions/97b1ce6dc89b48009fbcee3a8b6b43c1
Requested by: @wavecreator1