Upgrade from Java 6 to Java 11 (AB-163)#24
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade from Java 6 to Java 11 (AB-163)#24devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update Dropwizard BOM from 1.0.5 to 2.1.12, add dropwizard-dependencies BOM - Update maven-compiler-plugin to 3.13.0, use <release>11</release> - Update maven-surefire-plugin to 3.2.5 - Update maven-shade-plugin to 3.6.0, add module-info.class exclusion - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO.findAll() typing for Dropwizard 2.1.x Hibernate API - Migrate test from JUnit 3 to JUnit 5 (Jupiter) Co-Authored-By: Siddhant Seghal <siddxs5@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee project from Java 6 to Java 11 by bumping the Dropwizard framework from 1.0.5 to 2.1.12 and updating all Maven plugins and source code for compatibility.
Key changes:
${project.version}and pinned to2.1.12; addeddropwizard-dependenciesBOM<source>1.6</source>/<target>1.6</target>→<release>11</release>via maven-compiler-plugin 3.13.0module-info.classexclusion for Java 9+ uber JARs)@NotEmptyimport: Migrated from deprecatedorg.hibernate.validator.constraints.NotEmptytojavax.validation.constraints.NotEmptyQuery<Employee>to satisfy Dropwizard 2.1.x's stricterAbstractDAO.list()signaturejunit.framework) to JUnit 5 (org.junit.jupiter)Validated:
mvn clean verifypasses (compilation, tests, shaded JAR packaging).Review & Testing Checklist for Human
assertTrue(true). Runjava -jar target/DropwizardEmployee-1.0.5.jar server example.ymland confirmGET /employeeandPOST /employeework against the H2 database. This is the most important validation since no integration tests exist.EmployeeDAO.findAll()— the@SuppressWarnings("unchecked")cast fromQuery<?>toQuery<Employee>is a pragmatic fix for the Dropwizard 2.1.x API change. Confirm this is acceptable vs. switching to a typedCriteriaQueryapproach.Notes
example.ymlconfiguration andmigrations.xmlLiquibase changeset required no changes.Link to Devin session: https://app.devin.ai/sessions/9715e771bf3f4ae0b554873d62aa4ba1
Requested by: @wavecreator1