Upgrade Java 6 to Java 11 (AB-171)#25
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Java 6 to Java 11 (AB-171)#25devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Upgrade Dropwizard BOM from 1.0.5 to 2.1.12 (add dropwizard-dependencies BOM) - Update maven-compiler-plugin to 3.13.0 with <release>11</release> - Update maven-surefire-plugin to 3.2.5 - Update maven-shade-plugin to 3.6.0 with module-info.class exclusion - Update all other Maven plugins to modern versions - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO.findAll() Query<Employee> typing for Hibernate 5.x compatibility - Migrate test from JUnit 3 (TestCase) to JUnit 5 (Jupiter) Co-Authored-By: prem@cognition.ai <prem@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project from Java 6 (source/target 1.6) to Java 11, including a major Dropwizard framework upgrade from 1.0.5 to 2.1.12. This brings in Hibernate 5.x, Jersey 2.41, Jetty 9.4.53, and Jackson 2.13.x transitively.
Key changes:
${project.version}, pinned to2.1.12. Addeddropwizard-dependenciesBOM. Replaced<source>1.6</source>/<target>1.6</target>with<release>11</release>. Upgraded all Maven plugin versions. Addedmodule-info.classexclusion to shade plugin filter.@NotEmptyimport moved from deprecatedorg.hibernate.validator.constraintstojavax.validation.constraints.namedQuery()result fromQuery<?>toQuery<Employee>to satisfy Dropwizard 2.x's stricterAbstractDAO.list()signature.TestCase) to JUnit 5 (Jupiter).mvn clean verifypasses with zero compilation errors and all tests green.Review & Testing Checklist for Human
namedQuery()returnsQuery<?>in Hibernate 5.x; the cast toQuery<Employee>compiles but is unchecked. Confirm the named query"com.dropwizard.employee.core.Employee.findAll"returnsEmployeeentities as expected.java -jar target/DropwizardEmployee-1.0.5.jar server example.ymlwith Java 11 and verify the server starts,GET /employeereturns[], andPOST /employeecreates a record. The existing test suite is a singleassertTrue(true)and provides no real coverage.Notes
dropwizard-dependenciesBOM was added alongsidedropwizard-bomper prescriptive guidance to ensure all transitive dependency versions are managed consistently.Link to Devin session: https://app.devin.ai/sessions/f0163cfb9fbb4216a2a945e93addeea6
Requested by: @pqn