Upgrade Java 6 to Java 11 with Dropwizard 2.1.12#27
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Java 6 to Java 11 with Dropwizard 2.1.12#27devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update maven-compiler-plugin to 3.13.0, use <release>11</release> - Upgrade Dropwizard BOM from 1.0.5 to 2.1.12 - Add dropwizard-dependencies BOM import - Update maven-surefire-plugin to 3.2.5 - Update maven-shade-plugin to 3.6.0, add module-info.class exclusion - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO.findAll() typing for Dropwizard 2.x Hibernate API - Migrate test from JUnit 3 to JUnit 5 (Jupiter) Co-Authored-By: prem@cognition.ai <prem@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee application from Java 6 to Java 11, including a major Dropwizard framework bump from 1.0.5 to 2.1.12.
Build changes (
pom.xml):${project.version}and pinned to2.1.12; addeddropwizard-dependenciesBOMmaven-compiler-plugin3.6.0 → 3.13.0 with<release>11</release>(replaces<source>1.6</source>/<target>1.6</target>)maven-surefire-plugin2.19.1 → 3.2.5maven-shade-plugin2.4.3 → 3.6.0 withmodule-info.classexclusion for uber-JAR compatibilitySource changes:
EmployeeConfiguration.java:@NotEmptyimport moved from deprecatedorg.hibernate.validator.constraintstojavax.validation.constraintsEmployeeDAO.java: Added unchecked cast onnamedQuery()return toQuery<Employee>to satisfy Dropwizard 2.x's stricter Hibernate genericsAppTest.java: Migrated from JUnit 3 (TestCase) to JUnit 5 (Jupiter@Test)mvn clean verifypasses with zero compilation errors and all tests green.Review & Testing Checklist for Human
assertTrue(true)). Manually runjava -jar target/DropwizardEmployee-1.0.5.jar server example.ymlwith Java 11 and confirm the app boots, Hibernate initializes, and/employeeendpoints respond correctly.EmployeeDAO.findAll(): ThenamedQuery()→Query<Employee>cast is standard but suppresses a type-safety warning. Confirm the named queryEmployee.findAllreturns the expected entity type at runtime.Notes
${project.version}(1.0.5), coupling framework version to artifact version. This PR decouples them so the project version remains 1.0.5 while Dropwizard is at 2.1.12.Link to Devin session: https://app.devin.ai/sessions/83dd5b09a1bf4e3faee5cefbac283d7d
Requested by: @pqn