Upgrade Java 6 to Java 11 with Dropwizard 2.1.12 (AB-183)#28
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Java 6 to Java 11 with Dropwizard 2.1.12 (AB-183)#28devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update maven-compiler-plugin to 3.13.0 with <release>11</release> - Upgrade Dropwizard BOM from 1.0.5 to 2.1.12 - Add dropwizard-dependencies BOM import - Upgrade all Maven plugins to Java 11 compatible versions: - maven-shade-plugin 2.4.3 -> 3.6.0 - maven-surefire-plugin 2.19.1 -> 3.2.5 - maven-enforcer-plugin 1.4.1 -> 3.4.1 - maven-clean-plugin 2.6.1 -> 3.1.0 - maven-install-plugin 2.5.2 -> 3.1.1 - maven-resources-plugin 2.7 -> 3.3.1 - maven-source-plugin 2.4 -> 3.3.0 - maven-jar-plugin 2.6 -> 3.3.0 - maven-deploy-plugin 2.8.2 -> 3.1.1 - maven-site-plugin 3.4 -> 3.12.1 - Add module-info.class exclusion to shade plugin filters - Fix @notempty import: hibernate-validator -> javax.validation - Fix EmployeeDAO.findAll() typing for Hibernate 5.x Query API - Migrate test from JUnit 3 to JUnit 5 (Jupiter) - Add project.build.sourceEncoding UTF-8 property Jira: AB-183 Co-Authored-By: prem@cognition.ai <prem@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee project from Java 6 to Java 11, including a Dropwizard framework upgrade from 1.0.5 to 2.1.12 and all Maven plugin version bumps.
Key changes:
<source>1.6</source>/<target>1.6</target>→<release>11</release>${project.version}, addeddropwizard-dependenciesBOM)@NotEmptyimport:org.hibernate.validator.constraints.NotEmpty→javax.validation.constraints.NotEmpty(old import removed in Hibernate Validator 6.x)EmployeeDAO.findAll(): Added explicit cast toQuery<Employee>to satisfy Hibernate 5.x's stricter generics onAbstractDAO.list()TestCase) → JUnit 5 (Jupiter), since Dropwizard 2.x ships JUnit 5module-info.classexclusion to prevent conflicts in uber-JARmvn clean verifypasses with zero compilation errors and all tests green.Review & Testing Checklist for Human
assertTrue(true)— CI passing does NOT validate runtime behavior. Runjava -jar target/DropwizardEmployee-1.0.5.jar server example.ymland hitGET /employeeandPOST /employeeto confirm the Dropwizard 2.x upgrade didn't break request handling or Hibernate session management.EmployeeDAO.findAll()— the@SuppressWarnings("unchecked")cast fromQuery<?>toQuery<Employee>is a common Hibernate 5 pattern but masks potential type errors. Consider whether a typedCriteriaQueryapproach would be safer long-term.@NotEmptyvalidation behavior is unchanged —javax.validation.constraints.NotEmptyshould behave identically to the old Hibernate-specific one, but verify that thetemplateanddefaultNamefields inEmployeeConfigurationstill reject blank values on startup.Notes
Link to Devin session: https://app.devin.ai/sessions/c00be4a91f574eef82605444f7c817ff
Requested by: @pqn