Upgrade Java 6 to Java 11 (AB-187)#29
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Java 6 to Java 11 (AB-187)#29devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update Dropwizard BOM from 1.0.5 to 2.1.12 (decoupled from project version) - Add dropwizard-dependencies BOM import - Update maven-compiler-plugin to 3.13.0, use <release>11</release> - Update maven-surefire-plugin to 3.2.5 - Update maven-shade-plugin to 3.6.0, add module-info.class exclusion - Fix @notempty import: org.hibernate.validator.constraints -> javax.validation.constraints - Fix EmployeeDAO.findAll() typing for Hibernate 5.x Query generics - Migrate test from JUnit 3 (junit.framework) to JUnit 5 (Jupiter) Co-Authored-By: prem@cognition.ai <prem@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the DropwizardEmployee project from Java 6 to Java 11. This required a major Dropwizard framework upgrade (1.0.5 → 2.1.12) since Dropwizard 1.x does not support Java 11.
Build changes (
pom.xml):${project.version}— pinned to2.1.12dropwizard-dependenciesBOM import for transitive dependency managementmaven-compiler-plugin3.6.0 → 3.13.0, switched<source>/<target> 1.6to<release>11</release>maven-surefire-plugin2.19.1 → 3.2.5maven-shade-plugin2.4.3 → 3.6.0, addedmodule-info.classexclusion for Java 9+ uber-JAR compatibilitySource changes:
EmployeeConfiguration.java:@NotEmptyimport moved from deprecatedorg.hibernate.validator.constraintsto standardjavax.validation.constraintsEmployeeDAO.java: Added explicit cast ofnamedQuery()result toQuery<Employee>to satisfy Hibernate 5.x generics inAbstractDAO.list()AppTest.java: Migrated from JUnit 3 (junit.framework.TestCase) to JUnit 5 (org.junit.jupiter.api)mvn clean verifypasses (compilation + tests + shaded JAR packaging).Review & Testing Checklist for Human
java -jar target/DropwizardEmployee-1.0.5.jar server example.ymland hitGET /employeeandPOST /employee— the existing test only assertsassertTrue(true)and does not exercise any real functionalityexample.ymlEmployeeDAO.java:26): The@SuppressWarnings("unchecked")cast fromQuery<?>toQuery<Employee>is safe for this named query, but confirm this pattern is acceptable going forwardNotes
pom.xmltied Dropwizard's BOM version to${project.version}(1.0.5), which coincidentally matched Dropwizard 1.0.5. This coupling has been removed.assertTrue(true). Runtime verification is strongly recommended.Link to Devin session: https://app.devin.ai/sessions/19fe50cd192b4073a1fb9f0270d76e31
Requested by: @pqn