Upgrade Dropwizard BOM from 1.0.5 to 4.0.7#35
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade Dropwizard BOM from 1.0.5 to 4.0.7#35devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Add <properties> section with <dropwizard.version>4.0.7</dropwizard.version>
- Update BOM import to use ${dropwizard.version} instead of ${project.version}
- Keep project version as 1.0.5
Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decouples the Dropwizard BOM version from
${project.version}and upgrades it to 4.0.7.<properties>section with<dropwizard.version>4.0.7</dropwizard.version><version>from${project.version}(1.0.5) to${dropwizard.version}(4.0.7)1.0.5(unchanged)This PR only changes
pom.xml. The javax → jakarta source code migration required by Dropwizard 4.x will be handled in a separate follow-up PR. The project will not compile until that migration is complete.Review & Testing Checklist for Human
dropwizard-core,dropwizard-auth,dropwizard-assets,dropwizard-http2,dropwizard-hibernate,dropwizard-migrations,dropwizard-views-freemarker,dropwizard-views-mustache,dropwizard-metrics-graphite,dropwizard-testing) exist in version 4.0.7<version>1.0.5</version>on line 7 is unchangedNotes
${project.version}, which only worked because the project version (1.0.5) coincidentally matched the intended Dropwizard version. This PR makes the dependency explicit.mvn clean verifyto confirm the full build passes.Link to Devin session: https://app.devin.ai/sessions/ce3e64a3e3ff40cd8cd78e913ded1939
Requested by: @WesternConcrete