Upgrade Dropwizard 1.0.5 → 4.0.14, Java 6 → 17, all Maven plugins, add OWASP CVE scanning#44
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
…add OWASP Workstream 1: Dropwizard 1.0.5 -> 4.0.14 - Import dropwizard-dependencies and dropwizard-bom BOMs - Migrate io.dropwizard.* to io.dropwizard.core.* (Application, Configuration, Bootstrap, Environment) - Migrate io.dropwizard.views.ViewBundle to io.dropwizard.views.common.ViewBundle - Migrate javax.* to jakarta.* (validation, persistence, ws.rs) - Fix @notempty import from org.hibernate.validator to jakarta.validation - Fix DAO namedQuery() to namedTypedQuery() for Hibernate 6.x compatibility - Migrate JUnit 3 test to JUnit 5 (Jupiter) - H2 2.3.232 resolves CVE-2021-42392 and CVE-2022-23221 Workstream 2: Java compilation target 1.6 -> 17 - Replace source/target 1.6 with release 17 in maven-compiler-plugin - Add module-info.class exclusion in shade plugin Workstream 3: Upgrade all Maven plugins - maven-clean-plugin: 2.6.1 -> 3.5.0 - maven-install-plugin: 2.5.2 -> 3.1.4 - maven-surefire-plugin: 2.19.1 -> 3.5.5 - maven-resources-plugin: 2.7 -> 3.5.0 - maven-enforcer-plugin: 1.4.1 -> 3.6.2 - maven-compiler-plugin: 3.6.0 -> 3.15.0 - maven-source-plugin: 2.4 -> 3.4.0 - maven-jar-plugin: 2.6 -> 3.5.0 - maven-shade-plugin: 2.4.3 -> 3.6.2 - maven-deploy-plugin: 2.8.2 -> 3.1.4 - maven-site-plugin: 3.4 -> 3.21.0 Workstream 4: Add OWASP Dependency-Check Maven plugin - Add dependency-check-maven 12.1.3 - Configured to fail build on CVSS >= 7 Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coordinated upgrade addressing all security and dependency issues across four parallel workstreams:
Workstream 1: Dropwizard 1.0.5 → 4.0.14
dropwizard-dependenciesanddropwizard-bomBOMs at version 4.0.14io.dropwizard.Application→io.dropwizard.core.Application,Configuration,Bootstrap,Environmentio.dropwizard.views.ViewBundle→io.dropwizard.views.common.ViewBundlejavax.*→jakarta.*(validation, persistence, ws.rs)@NotEmptyimport:org.hibernate.validator.constraints→jakarta.validation.constraintsnamedQuery()→namedTypedQuery()for Hibernate 6.x compatibilityWorkstream 2: Java 6 → 17
<source>1.6</source>/<target>1.6</target>with<release>17</release>module-info.classexclusion to shade plugin filterWorkstream 3: Maven plugin upgrades (all to latest stable)
Workstream 4: OWASP Dependency-Check
dependency-check-maven12.1.3 pluginKey transitive dependency versions (verified via
mvn dependency:tree)Review & Testing Checklist for Human
mvn clean verify -Dliquibase.should.run=false -Ddependency-check.skip=truecompiles and tests pass with JDK 17mvn dependency-check:checkto confirm OWASP scan reports no critical CVEs (requires NVD API key for full scan; set-DnvdApiKey=...)java -jar target/DropwizardEmployee-4.0.14.jar server example.yml— confirm app starts on ports 8080/8081POST /employeeandGET /employeeendpoints work correctlyjavax.servlet→jakarta.servletNotes
${project.version}) as per the original design — now 4.0.14example.ymlH2 JDBC URL (jdbc:h2:./target/example) is compatible with H2 2.x without changesverifyphase; skip with-Ddependency-check.skip=truefor faster dev buildsLink to Devin session: https://app.devin.ai/sessions/231ee998c3c24edfa396d52a5667adc1
Requested by: @WesternConcrete
Devin Review