fix: add missing zone.js dev dependency for tests#1
fix: add missing zone.js dev dependency for tests#1devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
🔴 @angular/core upgraded to 21.2.4 while all other @angular/ packages remain at 21.1.1, violating peer dependency contracts*
Only @angular/core was bumped from 21.1.1 to 21.2.4, but every other Angular package (@angular/common, @angular/forms, @angular/router, @angular/platform-browser, @angular/platform-browser-dynamic, @angular/animations, @angular/compiler-cli) remains at 21.1.1. Angular packages use exact version peer dependencies to enforce lockstep versioning. According to the lockfile:
@angular/common@21.1.1requires@angular/core: 21.1.1(exact)@angular/forms@21.1.1requires@angular/core: 21.1.1(exact)@angular/router@21.1.1requires@angular/core: 21.1.1(exact)@angular/platform-browser@21.1.1requires@angular/core: 21.1.1(exact)@angular/platform-browser-dynamic@21.1.1requires@angular/core: 21.1.1(exact)@angular/animations@21.1.1requires@angular/core: 21.1.1(exact)@angular/core@21.2.4itself requires@angular/compiler: 21.2.4(exact), but@angular/compileris at21.1.1
This mismatch can cause subtle runtime incompatibilities between Angular's internal APIs, since the packages are designed and tested as a cohesive unit at each version.
(Refers to line 32)
Prompt for agents
All @angular/* packages must be upgraded together to the same version. In package.json, either revert @angular/core back to 21.1.1, or upgrade ALL Angular packages to 21.2.4. The packages that need to match are: @angular/animations, @angular/common, @angular/compiler, @angular/core, @angular/forms, @angular/platform-browser, @angular/platform-browser-dynamic, @angular/router (in dependencies), and @angular/build, @angular/cli, @angular/compiler-cli (in devDependencies). After updating package.json, run bun install to regenerate bun.lock.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
This version mismatch (@angular/core: 21.2.4 vs all other @angular/* at 21.1.1) is pre-existing on main — it was already present before this PR. This PR only adds zone.js as a devDependency; no Angular package versions were changed. Fixing the Angular version skew is out of scope for this change.
Summary
Unit tests (
bun run test) fail becausezone.jsis imported in all 6 spec files and insrc/test-setup.ts, but was never listed as a dependency. This PR addszone.jsas a devDependency so all 180 tests pass.Review & Testing Checklist for Human
@angular/corebump (21.1.1 → 21.2.4): Runningbun addalso synced the lockfile to matchpackage.json, which already declared"@angular/core": "21.2.4". This is a side-effect of the install, not an intentional upgrade. Verify this minor version bump doesn't introduce regressions.bun run test -- --runand confirm all 180 tests pass.bun run buildand confirm the production build succeeds.Notes
zone.js@0.16.1satisfies Angular's peer dependency requirement (~0.15.0 || ~0.16.0).zone.js(the app runs zoneless); it is only needed by the test harness (BrowserDynamicTestingModule/platformBrowserDynamicTesting).Link to Devin session: https://app.devin.ai/sessions/cd63f166f9924ff7862d56e753ee9142
Requested by: @matthewguerra-cog