Skip to content

fix: Upgrade Angular packages to resolve all Snyk vulnerabilities#14

Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1776854558-fix-snyk-vulnerabilities
Open

fix: Upgrade Angular packages to resolve all Snyk vulnerabilities#14
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1776854558-fix-snyk-vulnerabilities

Conversation

@devin-ai-integration
Copy link
Copy Markdown

Summary

Upgrades all Angular packages to their latest 21.2.x patch releases to resolve 16 SCA vulnerabilities identified by Snyk, including 2 critical (SSRF), 9 high (ReDoS, uncaught exceptions, missing auth, data amplification), and 5 medium/low severity issues.

Version changes:

  • @angular/animations, common, compiler, core, forms, platform-browser, platform-browser-dynamic, router: 21.1.121.2.9
  • @angular/core: 21.2.421.2.9
  • @angular/build, cli: 21.1.121.2.7 (latest available for these packages)
  • @angular/compiler-cli: 21.1.121.2.9

These upgrades transitively fix vulnerable versions of undici, vite, ajv, picomatch, @schematics/angular, and @modelcontextprotocol/sdk.

Not addressed in this PR:

  • SAST findings (hardcoded test credentials in spec/e2e files) — these are low severity and in test code only
  • Unmanaged C/C++ finding (cockpit-project/cockpit) — system-level dependency, not controllable via npm

Review & Testing Checklist for Human

  • Verify Angular version compatibility: @angular/build and @angular/cli are at 21.2.7 while runtime packages are at 21.2.9. Confirm this version split does not cause build or runtime issues in your environment.
  • Check package-lock.json addition: The repo previously used bun.lock. Verify this new package-lock.json doesn't conflict with your team's package manager workflow (npm vs bun).
  • Run the app locally (npm start or bun start) and verify it loads and functions correctly — the build succeeded in CI but a manual smoke test is recommended.
  • Run Snyk scan to confirm all SCA vulnerabilities are resolved post-merge.

Notes

  • npm install reports 0 vulnerabilities after the upgrade.
  • ng build completes successfully with the upgraded packages.
  • Prettier formatting check passes with no changes needed.

Link to Devin session: https://app.devin.ai/sessions/301f0711f6844c3ca0959ed872c143be
Requested by: @SachetCognition

Upgrade all Angular packages from 21.1.1 to 21.2.x (latest patches):
- @angular/animations, common, compiler, core, forms, platform-browser,
  platform-browser-dynamic, router: 21.1.1 -> 21.2.9
- @angular/build, cli: 21.1.1 -> 21.2.7
- @angular/compiler-cli: 21.1.1 -> 21.2.9

This resolves 17 SCA vulnerabilities including:
- 2 Critical: SSRF in @angular/build and @schematics/angular (CVE-2026-27739)
- 9 High: undici (4 CVEs), vite (2 CVEs), ajv ReDoS, picomatch ReDoS,
  @modelcontextprotocol/sdk race condition
- 4 Medium: prototype pollution, HTTP smuggling, CRLF injection, directory traversal
- 1 Low: XSS in @angular/compiler (CVE-2026-32635)

Co-Authored-By: sachet.agarwal <sachet.agarwal@windsurf.com>
@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration
Copy link
Copy Markdown
Author

Testing Results: Angular Package Upgrade Verification

Ran the app locally against dev server at localhost:4200 with upgraded Angular 21.2.x packages. All tests passed.

Test 1: Home page loads with articles and tags — PASSED

Home page renders correctly with Conduit banner, "Global Feed" tab active, multiple articles with authors/dates/tags, and "Popular Tags" sidebar populated from the API.

Home page

Test 2: Client-side routing and lazy loading — PASSED
Tag filtering at /tag/javascript Login page lazy-loaded at /login
Tag navigation Login page

All navigations were client-side (no full page reloads). Lazy-loaded components loaded correctly.

Test 3: No Angular framework errors in console — PASSED

Console shows only "Angular is running in development mode" — no errors, no chunk loading failures. Angular version confirmed as 21.2.9 via ng-version attribute.

Clean console

Build & Scan Verification
Check Result
npm install 0 vulnerabilities
ng build (production) Success in 7.4s
ng serve (dev) Success in 3.3s
prettier --check All files pass
Snyk SCA re-scan 0 npm vulnerabilities

Devin session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants