feat: implement DORA metric calculation engine (DF, LT, MTTR, CFR) [RR-59]#15
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: implement DORA metric calculation engine (DF, LT, MTTR, CFR) [RR-59]#15devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Add calculation logic that transforms raw pipeline events into the four DORA metrics: - Deployment Frequency from successful deploy count over a period - Lead Time from first commit timestamp to deploy timestamp - Mean Time to Restore from incident open to resolve timestamps - Change Failure Rate from failed deploys / total deploys Each metric includes a rating (elite/high/medium/low) based on DORA research benchmarks. Includes 36 unit tests covering all calculations, edge cases, and rating thresholds. Resolves: RR-59 Co-Authored-By: unknown <>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
dorafeature module with aDoraMetricsServicethat transforms raw pipeline events (deploys, commits, incidents) into the four DORA metrics:Each metric is rated
elite | high | medium | lowbased on hardcoded thresholds. AcalculateAll()convenience method computes all four at once.This is calculation logic only — no API integration, no UI, no route. The service is registered as
providedIn: 'root'but has no consumers yet.36 Vitest unit tests cover all calculations, rating thresholds, edge cases (empty inputs, zero periods, all-failed/all-success), and median computation for odd/even counts.
Review & Testing Checklist for Human
rate*methods (e.g., elite DF ≥ 1/day, elite LT ≤ 24h, elite MTTR ≤ 1h, elite CFR ≤ 5%). These are not configurable — confirm they align with team standards.new Date(string)with no format validation; invalid timestamps would produceNaNresults silently. Theservicefield on events is present in the model but not used for filtering — all events are processed together.Notes
new DoraMetricsService()) rather than through Angular TestBed, since the service has zero Angular DI dependencies. This avoids the pre-existingzone.jsmissing-dependency issue in the test setup.servicefield on event models is available for future per-service filtering but is not currently used in calculations.Link to Devin session: https://app.devin.ai/sessions/04b630c9eed34b9281b656b35421e447