153 we need to be able to define a mix of input files#154
Open
153 we need to be able to define a mix of input files#154
Conversation
added 2 commits
July 24, 2023 17:21
based on a 2-column input <file survey_name> <photometry filepath>
LightCurve instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal : allows to load a set of files not necessarily coming from one kind (SNPCC, PLASTICC, etc...), which will make unit testing and usage of the codebase a bit more natural:
Direct consequence : no need to save lightcurves or features info into files, and much more natural API to prepare for the DB access extension.