This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Update for GA4GH Service-info #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
reviewed
Sep 16, 2019
Contributor
blankdots
left a comment
blankdots
left a comment
There was a problem hiding this comment.
Should we add the information specific to GA4GH to be validated as part of info schema https://github.com/CSCfi/beacon-python/blob/master/beacon_api/schemas/info.json ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GA4GH Discovey Service-Info has been updated, and this PR brings beacon-python up-to-date with that.
Type of change
Changes Made
service_typetoconfig.iniwhich refers to GA4GH DiscoverygroupIdandartifactId;environmenttoconfig.iniwhich states application environment (test, dev, prod);/service-info;1.4.0to1.4.1.Testing
Mentions
GA4GH Discovery is marked to have a
1.0.0release coming soon.