Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Conversation

@teemukataja
Copy link
Contributor

Description

Add option --min_allele_count to beacon_init tool to be able to ignore rare alleles.

Examples

  • Default: minimum allele count by default is 1, all variants will be loaded into the database
  • --min_allele_count 20 only variants that have an allele count of at least 20 will be loaded into the database

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • New feature to db_load.py
  • Updated docs
  • Updates unit tests
  • Bumped feature number

Testing

  • Unit Tests
  • Manual QA

Mentions

Requested by THL Biobank.

@teemukataja teemukataja added the enhancement New feature or request label Nov 25, 2020
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, not mandatory to fix but some comments:
1.7.2 - > 1.7.3 minor version update as it is not that radical change
I would match the same number of parameters in load_datafile to keep it consistent and avoid similar issues

@teemukataja teemukataja merged commit a599cde into dev Nov 25, 2020
@teemukataja teemukataja deleted the feature/beacon-init-min-ac branch November 25, 2020 09:56
@teemukataja teemukataja mentioned this pull request Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants