-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
teemukataja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handovers are an optional feature, and should not be added to the responses always. If drs is configured, this would mean that the handover feature is enabled, and only then should the field be added to the response. If drs in config.ini is empty, don't add these fields.
b8b8e65 to
db5b573
Compare
blankdots
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address @teemukataja things and we are good to go.
I have an idea how to make this more general and allow multiple types of handovers, but this requires changes to the configuration and it should not be part of this PR.
blankdots
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be followed by a PR for Docs.
|
Commented the |
… to keep old tests working(if drs is commented from config), and reduce dict transformations
Pull Request Template
Description
Basic handover support.
A proof of concept for handovers. See our development beacon for examples.
The available handovers are all set in the
config.iniat the moment. If you prefer another type of configuration, we would be happy to discuss it.Related issues
Fixes #38
Type of change
Changes Made
Testing
Mentions