Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Conversation

@MalinAhlberg
Copy link
Collaborator

@MalinAhlberg MalinAhlberg commented Mar 27, 2019

Pull Request Template

Description

Basic handover support.
A proof of concept for handovers. See our development beacon for examples.

The available handovers are all set in the config.ini at the moment. If you prefer another type of configuration, we would be happy to discuss it.

Related issues

Fixes #38

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (this needs a follow up PR)

Changes Made

Testing

  • Unit Tests
  • Integration Tests
  • Tests do not apply
  • Needs testing (start an issue or do a follow up PR about it)

Mentions

Copy link
Contributor

@teemukataja teemukataja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handovers are an optional feature, and should not be added to the responses always. If drs is configured, this would mean that the handover feature is enabled, and only then should the field be added to the response. If drs in config.ini is empty, don't add these fields.

@teemukataja teemukataja force-pushed the feature/add_handover branch from b8b8e65 to db5b573 Compare April 1, 2019 07:15
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address @teemukataja things and we are good to go.

I have an idea how to make this more general and allow multiple types of handovers, but this requires changes to the configuration and it should not be part of this PR.

Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be followed by a PR for Docs.

@teemukataja
Copy link
Contributor

teemukataja commented Apr 2, 2019

Commented the drs from config.ini so that the handover-feature is disabled by default on master. To re-enable handover-feature one can uncomment the drs variable from config.ini.

… to keep old tests working(if drs is commented from config), and reduce dict transformations
@blankdots blankdots added the enhancement New feature or request label Apr 2, 2019
@blankdots blankdots merged commit f9ddcf3 into master Apr 2, 2019
@blankdots blankdots deleted the feature/add_handover branch April 2, 2019 09:33
teemukataja added a commit that referenced this pull request Apr 2, 2019
@teemukataja teemukataja mentioned this pull request Apr 2, 2019
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Investigate) Support for handover method for data access

4 participants