This repository was archived by the owner on Oct 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teemukataja
approved these changes
Apr 18, 2019
Co-Authored-By: blankdots <blankdots@users.noreply.github.com>
…o feature/matename
7992444 to
da16f4d
Compare
MalinAhlberg
approved these changes
Apr 22, 2019
blankdots
commented
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first attempt at dealing with mateName.
It would be desirable in a response to get also the mate corresponding to the searched(DONE)mateName, but as the specification is not clear on what should it contain, it is difficult to make guesses what should be in the response.yes also
"alternateBases": "N[CHR10:121482216[",is not an alternate base.The query in
mate_nameis quite verbose, and I am open to any suggestions to improve it.Related issues
Fixes #56
Type of change
This change requires a documentation update (this needs a follow up PR)(DONE)Changes Made
beacon_mate_tablethat contains mate fusion specific fieldsbeacon.extensions.mate_namethat contains a custom query for mate fusionBNDTesting
These queries should work:
localhost:5050/query?referenceName=1&referenceBases=N&start=108796059&assemblyId=GRCh38&variantType=BND&end=121482216&datasetIds=urn:hg:1000genome&includeDatasetResponses=HITlocalhost:5050/query?referenceName=1&referenceBases=N&start=108796059&assemblyId=GRCh38&mateName=10&end=121482216&datasetIds=urn:hg:1000genome&includeDatasetResponses=HITlocalhost:5050/query?referenceName=1&referenceBases=N&startMin=108796058&startMax=108796059&assemblyId=GRCh38&mateName=10&endMin=121482215&endMax=121482216&datasetIds=urn:hg:1000genome&includeDatasetResponses=HITThe response as of now is like:
a few tests added so far(90% coverage)That will be the job of integration tests, as soon as we will have a proper VCF mate fusion data.
Mentions
There will be a follow-up PR with docs and more tests.
It is a design decision to separate those mate fusion from the main data table, but also open to improvement suggestions.