This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Make sample queries more easily configurable #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinAhlberg
commented
May 13, 2019
MalinAhlberg
commented
May 13, 2019
blankdots
approved these changes
May 13, 2019
Contributor
blankdots
left a comment
blankdots
left a comment
There was a problem hiding this comment.
It would be nice in the long term if we could generate these example somehow, or start an issue and think about it.
teemukataja
approved these changes
May 13, 2019
Contributor
One solution could be, that we extract a few rows from the DB as example queries (only PUBLIC datasets). |
Co-Authored-By: Teemu Kataja <kataja.teemu@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow a
sample_queries.jsonfile inbeacon_api/confwith sample queries to show in theinfocall, instead of the ones inbeacon_api/api/info.py.Makes it easier to have your own sample queries, since you will not need to edit the
beacon_api/api/info.pyto change this.Type of change
Changes Made
Add another optional config-file, the content of this will be stored in
__sample_queries__.