Added Template Website for the Communities#18
Merged
SithuSoe04 merged 3 commits intomainfrom Jan 30, 2025
Merged
Conversation
SithuSoe04
requested changes
Dec 14, 2024
Collaborator
SithuSoe04
left a comment
SithuSoe04
left a comment
There was a problem hiding this comment.
Great work! Looks good to me overall. A few minor fixes to be made before merge:
- Make the button consistent with buttons on the other pages.
- The Meet the Team section should not have 4 tabs since each community will be having their own page. Remove the tabs so that the user only sees the people in the appropriate teams.
- The left and right arrow (to go back and front) in the Meet The Team section is on the edge of the pages. Move the arrows closer to the pictures so that it feels more natural to click on the arrows.
Feel free to submit a new PR once you have make the changes!
… to the center, and matched other buttons to the same style as other page
Collaborator
|
The previous/next button looks fine when there are six people showing in the section. However, when there are only three people on the page, the buttons become misaligned. Can you please fix this? 
|
Collaborator
|
Good work! |
SithuSoe04
approved these changes
Jan 30, 2025
SithuSoe04
deleted the
feature/lucashlaing-OscarKhaing/FE-TemplateWebsite
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Template Website for the Communities. Is accessible through the /templatewebsite URL.