Allow committee-elect to update actions (and appear in auto-complete) #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
All these failed tests do not look good for the software engineering job I'll be starting in 3 months where my primary language will be Python |
MattyTheHacker
requested changes
May 24, 2025
Co-authored-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com> Signed-off-by: Holly <25277367+Thatsmusic99@users.noreply.github.com>
Co-authored-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com> Signed-off-by: Holly <25277367+Thatsmusic99@users.noreply.github.com>
MattyTheHacker
previously approved these changes
May 24, 2025
…oB/TeX-Bot-Py-V2 into allow-committee-elect-action-update
MattyTheHacker
added
bug
CarrotManMatt
requested changes
May 26, 2025
MattyTheHacker
added
the
sync
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR allows committee-elect users to update actions and appear in auto-complete while adjusting permission checks for updating and listing actions.
- Added committee-elect role handling to the auto-complete command.
- Removed committee role requirement from update_status and list_user_actions to allow non-committee users to update/view their own actions.
- Updated action member retrieval and permission error responses in list_user_actions.
Comments suppressed due to low confidence (2)
cogs/committee_actions_tracking.py:134
- Consider adding a brief comment explaining the purpose and usage of 'committee_elect_role' for auto-complete to assist future maintainers.
committee_elect_role: discord.Role | None = None
cogs/committee_actions_tracking.py:292
- Ensure that tests are updated or added to verify that non-committee users can update their own actions after removing this committee role check.
@CommandChecks.check_interaction_user_has_committee_role
CarrotManMatt
requested changes
Jun 13, 2025
CarrotManMatt
requested changes
Jun 14, 2025
Co-authored-by: Matt Norton <matt@carrotmanmatt.com> Signed-off-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com>
Co-authored-by: Matt Norton <matt@carrotmanmatt.com> Signed-off-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com>
CarrotManMatt
approved these changes
Jun 15, 2025
MattyTheHacker
added a commit
that referenced
this pull request
Jun 15, 2025
Signed-off-by: Holly <25277367+Thatsmusic99@users.noreply.github.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Matty Widdop <18513864+MattyTheHacker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507 and #506
Haven't been able to properly test, will need doing prior to merging - can always be spun up on the test server but I don't have the necessary configuration for it (and i use vim btw)