DB 연결 후 서버 시작#120
Open
gunhoflash wants to merge 2 commits intomasterfrom
Open
Conversation
iwanhae
reviewed
Oct 11, 2020
| .catch((e: Error) => { | ||
| throw (e); | ||
| }); | ||
| await mongoose.connect(secret.mongoURI, { |
Member
There was a problem hiding this comment.
이미 then 과 catch로 callback 구조를 이용하고 있는데 await이 같이 존재할 필요가 있을까요?
개인적으로는 깔끔한 코드를 위해 await, try, catch 문만 사용하고 then, catch는 없애버리는게 좋아보입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB 연결을 마친 후 서버를 시작할 수 있게 하고자 했습니다. 리뷰 부탁드립니다.