Skip to content

Add missing IocpProactor code to remove unregistered futures #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hosaka merged 1 commit into from
Oct 6, 2023
Merged

Add missing IocpProactor code to remove unregistered futures #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions qasync/_windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ def _poll(self, timeout=None):
status = _overlapped.GetQueuedCompletionStatus(self._iocp, ms)
if status is None:
break
ms = 0

err, transferred, key, address = status
try:
Expand All @@ -154,7 +155,6 @@ def _poll(self, timeout=None):
# handle which should be closed to avoid a leak.
if key not in (0, _overlapped.INVALID_HANDLE_VALUE):
_winapi.CloseHandle(key)
ms = 0
continue

if obj in self._stopped_serving:
Expand All @@ -163,7 +163,11 @@ def _poll(self, timeout=None):
elif not f.done():
self.__events.append((f, callback, transferred, key, ov))

ms = 0
# Remove unregistered futures
for ov in self._unregistered:
self._cache.pop(ov.address, None)
self._unregistered.clear()



@with_logger
Expand Down