modprobe: Hijack loading r8169 if r8125 is found#208
Conversation
Does not really fit, since its only one line of text and wouldn't do much |
For the RTL8125, RTL8162, and Realtek E3000 ethernet cards, both of these drivers serve the same purpose. However, some users have experienced dissatisfaction with the r8169 driver with these cards (slower speeds, etc). In almost all cases, r8125 solves these issues. Since 6.19.0, we started shipping r8125 as an in-tree module and stopped r8169 from loading for these devices. However, this driver causes issues with other hardware so we decided to make it opt-in via [1]. The next problem was how to get r8125 to load without it fighting for control with r8169. Shipping a blacklist config could work, but this causes all sorts of issues down the line as well, namely: 1. Kernels without the r8125 will have no internet connection because r8169 is blacklisted, especially tough for Arch kernel compatibility 2. Shipping a blacklist file for each <kernel>-r8125 is wasted disk space. Hijacking r8169 is also another solution. If the r8125 module is found, it will load that driver instead of r8169, else it will load r8169 as usual. [1] CachyOS/linux-cachyos@94aaba5 Signed-off-by: Eric Naim <dnaim@cachyos.org>
1Naim
force-pushed
the
fix/r8125-r8169
branch
from
7770ad4 to
5706dad
Compare
Couldn't we maybe just patch driver for this? |
We did when we were shipping it as an in-tree module, but the r8125 module doesn't work for everyone and it causes weird issues on certain setups so its now shipped as an external module. I don't think its possible to patch the driver in the current state. |
|
couldn't it be turned into an entry in cachy hello or on the wiki so users can remove the 8125 blacklist if they want that driver and if they dont and in the cases where its known to break to switch people over those people wouldnt be affected as it would be opt in |
|
Everything from the module and the blacklist is opt in. See https://github.com/CachyOS/linux-cachyos/blob/39737576a25091a3c4ca00729b769a1f92ec98d5/linux-cachyos/PKGBUILD#L795 |
|
I think it can be closed since CachyOS/linux-cachyos#778 have merged? |
4 participants
For the RTL8125, RTL8162, and Realtek E3000 ethernet cards, both of these drivers serve the same purpose. However, some users have experienced dissatisfaction with the r8169 driver with these cards (slower speeds, etc). In almost all cases, r8125 solves these issues.
Since 6.19.0, we started shipping r8125 as an in-tree module and stopped r8169 from loading for these devices. However, this driver causes issues with other hardware so we decided to make it opt-in via [1]. The next problem was how to get r8125 to load without it fighting for control with r8169.
Shipping a blacklist config could work, but this causes all sorts of issues down the line as well, namely:
Hijacking r8169 is also another solution. If the r8125 module is found, it will load that driver instead of r8169, else it will load r8169 as usual.
[1] CachyOS/linux-cachyos@94aaba5