Skip to content

Comments

Fixing #173, #186 - Data Source Selector and Standalone Maps#195

Merged
TheWitness merged 5 commits intodevelopfrom
popups
Feb 11, 2026
Merged

Fixing #173, #186 - Data Source Selector and Standalone Maps#195
TheWitness merged 5 commits intodevelopfrom
popups

Conversation

@TheWitness
Copy link
Member

This fix does the following:

This change simplifies the logic in weathermap.js to be less convoluted and encodes the data-hover string to reduce issues related to displaying embedded html inside of an html attribute.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses two reported weathermap plugin issues by optimizing editor autocomplete queries (Data Source selector) and making standalone-generated HTML maps include the necessary JS/CSS for hover popups, plus a small stats log message tweak.

Changes:

  • Optimize graph/data source autocomplete SQL in lib/editor.inc.php to reduce joins and broaden search matching.
  • Make standalone HTML exports self-contained enough to support hover popups by adding required assets and encoding hover payloads safely.
  • Adjust poller logging/HTML output handling and update the changelog.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
lib/poller-common.php Improves HTML output writability checks, generates standalone HTML output, and tweaks log message text.
lib/editor.inc.php Refactors graph/data source selector queries for performance and search behavior.
lib/WeatherMap.class.php Base64-encodes hover payloads and adds standalone HTML wrapper/assets via MakeHTML(..., $standalone=true).
lib/HTML_ImageMap.class.php Indentation-only changes to generated <area> HTML.
js/weathermap.js Decodes base64 hover payloads and adjusts tooltip behavior/DOM handling.
CHANGELOG.md Notes fixes for issues #173 and #186.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TheWitness and others added 4 commits February 11, 2026 10:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: TheWitness <thewitness@cacti.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: TheWitness <thewitness@cacti.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: TheWitness <thewitness@cacti.net>
@TheWitness TheWitness merged commit 22b16ea into develop Feb 11, 2026
4 checks passed
@TheWitness TheWitness deleted the popups branch February 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants