Adding a missing library and correct deprecation warning#198
Adding a missing library and correct deprecation warning#198TheWitness merged 3 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix two issues: adding a missing library include for Boost support and correcting a PHP 8.1+ deprecation warning related to dynamic properties. The first change adds the necessary include for lib/rrd.php which contains the rrdtool_function_fetch() function used when Boost is enabled. However, the second change has a critical issue - the down_cache variable declaration is added to the wrong class.
Changes:
- Added include for lib/rrd.php to support Boost functionality
- Added down_cache variable declaration (but to the wrong class - critical issue)
- Minor code style fix for spacing in conditional statement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| weathermap-cacti-rebuild.php | Adds include_once for lib/rrd.php to support rrdtool_function_fetch() calls when Boost is enabled |
| lib/WeatherMap.class.php | Adds down_cache variable declaration to WeatherMap class (incorrect - should be in WeatherMapDataSource_snmp2c) and minor spacing fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Correcting two minor issues.