Conversation
rra_id -> local_data_id data_id -> data_template_rrd_id
…ug in rrdtool version 1.4.8. rrdtool-1.4.8 is the version on RHEL7. This version enforces the three printf arguments being present in the fromat string. See: https://forum.network-weathermap.com/t/rrdtool-aggregate-target-has-no-valid-data-after-move-to-github-version/76/5 https://oss.oetiker.ch/rrdtool/doc/rrdgraph.en.html
fixed schema in WeatherMapDataSource_cactithold.php to use new fields.
This fixes the #1 issue
The last_value was not being filled with a default value, causing an issue during inserts.
button_go.gif has been removed from Cacti 1.x therefore changing to enable_icon.png as recommended by issue #2
The last_value column name is also a special keyword in MySQL. All column names have been escaped for table creation. last_value column name has been escaped in update statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.