Some fixes to make the cycle feature and hover graphs work in recent Cacti versions#9
Merged
thurban merged 3 commits intoCacti:masterfrom Jul 23, 2020
Merged
Conversation
There were 87 calls to eval() which is generally considered bad practice and current Cacti CSP instructs browsers to block these calls. There were also multiple legacy-insecure calls to setTimeout() using strings instead of functions with the same security problem. In this commit, some of these insecure funciton calls have been fixed to pass the current default Cacti CSP for 'script-src' which is 'self'. This is defined in an HTTP header in Cacti version 1.2.10 at <Cacti Root>/include/global.php:409
jamesbtate
changed the title
This is needed to make weathermap cycling work outside the full-screen mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "cycle" feature when viewing weathermaps was broken. The path to a JS file was wrong in the HTML in the main PHP file and a small change was needed in the map-cycle.js file.
The "hover" graphs on Weathermaps were not working because Cacti's CSP header does not allow the many unsafe/insecure calls to eval() and setTimeout() in overlib.js.
Both these problems can be seen in the browser's JS console when trying to cycle weathermaps.
It appears overlib.js has not been maintained for quite a while. I fixed some of the unsafe calls myself and left many unsafe calls that were not encountered in my usage of this Weathermap plugin in Cacti 1.2.10. It is time-consuming to fix these calls because many are a just different enough to make a reasonable regex replacement not work.