Unsafe model access of BlockEngineBase_BC8#getEngineParticles causing crash

[StockiesLad]

Crash Report
https://gist.github.com/StockiesLad/86d188f9a7309afcc57d085a99c04b29

Please complete the following information:

• Forge Version: 47.4.0 (1.20.1)
• BuildCraft Version (Add Hash if from github): 7.99.24.9-1.20.1-2025-04-26-all

To Reproduce
Steps to reproduce the behavior:
I am actually not sure what exactly triggers it. Breaking and placing the block doesn't trigger it directly, for some reason...

How to fix

 @OnlyIn(Dist.CLIENT)
    private TextureAtlasSprite getEngineParticle(IEngineType engineType) {
        return (TextureAtlasSprite)((LazyLoadedValue)engineParticles.computeIfAbsent(engineType, (e) -> {
            return new LazyLoadedValue(() -> {
                MutableQuad[] var1 = ((ModelHolderVariable)engineModels.get(e)).getCutoutQuads();
                int var2 = var1.length;

                for(int var3 = 0; var3 < var2; ++var3) {
                    MutableQuad quad = var1[var3];
                    if (quad.getFace() == Direction.DOWN) {
                        return quad.getSprite();
                    }
                }

                return (TextureAtlasSprite)SpriteUtil.missingSprite().get();
            });
        })).get();
    }

Instead of directly assigning to the MutableQuad[], perform a null check when performing engineModels.get(), where if null, print a warning, if not null, proceed with the iteration of quads. This will stop the crash, but might result in missingno textures.

[StockiesLad]

Here's an example mixin I used to patch it (again I wish I could get the main repo working 😭):

@Mixin(BlockEngineBase_BC8.class)
public class BlockEngineBaseMixin {
    @Shadow @Final public static Map<IEngineType, ModelHolderVariable> engineModels;

    @SuppressWarnings({"unchecked", "deprecation"})
    @Redirect(method = "getEngineParticle", at = @At(value = "INVOKE", target = "Ljava/util/Map;computeIfAbsent(Ljava/lang/Object;Ljava/util/function/Function;)Ljava/lang/Object;"))
    private <K, V> V mobsiege$FixParticleCrash(Map<K, V> instance, K k, Function<? super K, ? extends V> key, @Local(argsOnly = true) IEngineType engineType) {
        return instance.computeIfAbsent((K) engineType, k1 -> (V) new LazyLoadedValue<>(() -> {
            var model = engineModels.get(k1);
            if (model != null)
                for (MutableQuad quad : model.getCutoutQuads()) {
                    if (quad.getFace() == Direction.DOWN)
                        return quad.getSprite();
                }
            else LOGGER.warn("Engine particle model for {} is missing", k1);
            return SpriteUtil.missingSprite().get();
        }));
    }
}