Merged
Conversation
… steps alongside dockerfile
…pdate application configuration files
There was a problem hiding this comment.
Pull Request Overview
This PR adds GitHub Actions workflows for build and deployment while updating environment configurations and the Dockerfile.
- Updates production and local server port configurations
- Removes the hmg environment configuration file
- Modifies the Dockerfile to use a new JDK image, update the working directory, and improve security with a non-root user
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| infrastructure/src/main/resources/application.yml | Updates production port from 8080 to 80. |
| infrastructure/src/main/resources/application-local.yml | Adds a local environment configuration with server port 8080. |
| infrastructure/src/main/resources/application-hmg.yml | Removes the hmg configuration file. |
| infrastructure/src/main/resources/application-dev.yml | Adds a development configuration with environment variables. |
| Dockerfile | Switches to a new JDK base image, updates working directory, and adds a non-root user. |
| .github/workflows/*.yml | Adds GitHub Actions workflows for release, nightly, and latest builds. |
Comments suppressed due to low confidence (3)
infrastructure/src/main/resources/application-hmg.yml:1
- The removal of the hmg configuration file eliminates settings for keycloak, postgres, and storage; confirm that this environment is no longer required or that its configuration is handled elsewhere.
Entire file removed
infrastructure/src/main/resources/application.yml:2
- The production port has been changed from 8080 to 80; please ensure that this aligns with the overall network and architecture expectations and update corresponding documentation if needed.
port: 80
Dockerfile:3
- Changing the working directory from '/app' to '/usr/app' may affect relative path references in other scripts or configurations; verify that all references have been updated accordingly.
WORKDIR /usr/app
Member
|
top |
needkg
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Tipo de mudança
Adiciona GitHubActions.
Como foi testado?
Checklist