feat: add CORS configuration properties to support cross-origin requests#33
Merged
jhonatapers merged 1 commit intodevelopfrom May 27, 2025
Merged
feat: add CORS configuration properties to support cross-origin requests#33jhonatapers merged 1 commit intodevelopfrom
jhonatapers merged 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance CORS (Cross-Origin Resource Sharing) support and improve security configurations. Key updates include adding CORS-related properties, creating dedicated classes for handling CORS and Keycloak JWT conversions, and refactoring the
SecurityConfigclass to integrate these changes.Enhancements to CORS Configuration:
.env.example: Added environment variables for configuring CORS, including allowed origins, methods, headers, and credentials.infrastructure/src/main/resources/application-env.yml: Introduced CORS-related properties under thesecurity.corssection to allow dynamic configuration via environment variables.infrastructure/src/main/java/com/callv2/drive/infrastructure/configuration/properties/cors/CorsConfigurationProperties.java: Added a new class to encapsulate CORS properties for cleaner and centralized management.infrastructure/src/main/java/com/callv2/drive/infrastructure/configuration/security/SecurityConfig.java: Refactored theSecurityConfigclass to include aCorsConfigurationSourcebean and utilize the newCorsConfigurationPropertiesfor dynamic CORS setup. [1] [2]