fix: file creation validation and error handling in DefaultCreateFile…#40
Merged
jhonatapers merged 1 commit intodevelopfrom May 31, 2025
Merged
fix: file creation validation and error handling in DefaultCreateFile…#40jhonatapers merged 1 commit intodevelopfrom
jhonatapers merged 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances file creation functionality by improving validation and exception handling in the
DefaultCreateFileUseCaseclass and updating its corresponding test suite. Key changes include stricter validation for file names, enhanced quota checks, and additional test cases to cover new scenarios.Enhancements to validation and exception handling:
Notificationobject to collect validation errors, and aValidationExceptionis thrown if errors are present. (DefaultCreateFileUseCase.java, [1] [2]Error.withmethod for consistency when throwingQuotaExceededException. (DefaultCreateFileUseCase.java, application/src/main/java/com/callv2/drive/application/file/create/DefaultCreateFileUseCase.javaL62-R79)Test suite improvements:
NotFoundException.ValidationException.QuotaExceededException.ValidationException.givenAnInvalidId_whenCallsExecute_thenShouldThrowNotFoundExceptiontogivenAnInvalidFolderId_whenCallsExecute_thenShouldThrowNotFoundException.Code cleanup:
DefaultCreateFileUseCaseclass, as these are now handled earlier in the process. (DefaultCreateFileUseCase.java, application/src/main/java/com/callv2/drive/application/file/create/DefaultCreateFileUseCase.javaL78-L84)