Merged
Conversation
…re and post invocation processes
…Executor in executor chains
…on context management - Added InvocationContext interface to encapsulate context information during method invocation. - Refactored PostInvocationContext and PreInvocationContext to extend InvocationContext. - Implemented SimplePreInvocationContext and SimplePostInvocationContext to handle invocation context. - Updated SimpleExecutorChainHandlerBuilder to manage pre and post invocation executor chains using queues. - Created ApplicationLayerAspect to handle method execution with AOP. - Removed obsolete aspect-related classes and interfaces to streamline the AOP implementation. - Introduced logging executors for method arguments, signatures, and execution telemetry. - Configured AOP beans in AopConfig for logging and error handling during method execution.
… for improved context management
…spect and remove AopConfig class
… result or throw throwable based on success
…lerBuilder as final to prevent subclassing
…cution handling; enhance ApplicationLayerAspect with result logging refactor: update logging in LogErrorPostExecutor, LogMethodArgsPreExecutor, LogMethodResultPostExecutor, LogMethodSignaturePreExecutor, and LogTelemetryPostExecutor for consistency fix: implement toString method in FileJpaEntity for better logging
…roviding no-op chains
…Member, and MemberID classes for better logging and debugging
…dArgsPreExecutor, and LogMethodSignaturePreExecutor constructors
…nstantiation and extend Log4jLogger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new AOP (Aspect-Oriented Programming) executor framework and supporting context classes, along with some minor improvements to domain model classes. The main changes are the addition of a flexible executor chain system for handling method invocations with pre- and post-processing, as well as enhancements to the domain model for better debugging and logging.
AOP Executor Framework Implementation:
InvocationContext,PreInvocationContext,PostInvocationContext, and their concrete classes such asSimplePreInvocationContextandSimplePostInvocationContext. These manage the state and results of method invocations, including timing and exception handling. [1] [2] [3] [4] [5] [6]Executor,PreExecutor,PostExecutor,ExecutorChain,PreInvocationExecutorChain,PostInvocationExecutorChain) to enable composition of multiple processing steps before and after method invocations. [1] [2] [3] [4] [5] [6]ExecutorChainHandler,SimpleExecutorChainHandler,SimpleExecutorChainHandlerBuilder) for building and executing customizable chains of pre- and post-invocation logic, including error handling. [1] [2] [3]Build System:
build.gradlefor theaopmodule, configuring dependencies (AspectJ, JUnit, Mockito), Java 21 toolchain, and test setup.Domain Model Improvements:
toString()methods to domain entities (File,FileID,Folder,FolderID) for improved logging and debugging output. [1] [2] [3] [4]