Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature for listing member quotas, refactors related application and infrastructure layers, and updates the API to expose this functionality. The main changes include the addition of the
ListQuotasUseCaseand its implementation, integration with the API and controller, and supporting updates to the gateway and data mapping. Below are the most important changes grouped by theme:Application Layer: Member Quota Listing
ListQuotasUseCaseabstract class and its concrete implementationDefaultListQuotasUseCase, which retrieves paginated member quota data using the newListQuotaOutputrecord. (application/src/main/java/com/callv2/drive/application/member/quota/retrieve/list/ListQuotasUseCase.java,DefaultListQuotasUseCase.java,ListQuotaOutput.java) [1] [2] [3]QuotaListOutputrecord, replacing it with the more detailedListQuotaOutput. (application/src/main/java/com/callv2/drive/application/member/quota/retrieve/list/QuotaListOutput.java)Infrastructure Layer: Gateway and Repository Updates
findAll(SearchQuery)method inDefaultMemberGatewayto support paginated and filtered member queries, leveraging Spring Data JPA specifications and pagination. Updated constructor to injectFilterService. (infrastructure/src/main/java/com/callv2/drive/infrastructure/member/DefaultMemberGateway.java) [1] [2]MemberJpaRepositoryto support specification-based queries for member entities. (infrastructure/src/main/java/com/callv2/drive/infrastructure/member/persistence/MemberJpaRepository.java)API Layer: Endpoint and Controller Integration
listQuotasendpoint toMemberAdminAPIfor listing member quotas with pagination, ordering, and filtering options. (infrastructure/src/main/java/com/callv2/drive/infrastructure/api/MemberAdminAPI.java)MemberAdminController, wiring through the use case and mapping results to the response model. (infrastructure/src/main/java/com/callv2/drive/infrastructure/api/controller/MemberAdminController.java) [1] [2]Configuration and Data Mapping
MemberUseCaseConfigfor dependency injection. (infrastructure/src/main/java/com/callv2/drive/infrastructure/configuration/usecase/MemberUseCaseConfig.java)MemberQuotaListResponserecord and updatedMemberPresenterto map domain output to API response. (infrastructure/src/main/java/com/callv2/drive/infrastructure/member/model/MemberQuotaListResponse.java,MemberPresenter.java) [1] [2]These changes collectively enable efficient, paginated, and filterable listing of member quotas via the API, with proper separation of concerns and mapping between layers.