feat: add quantity field to goal and session objects#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it is possible to associate a quantity each session. For example the page of a book, the remaning pages or the flashcards studied in a session.
add_goal now has an optional quantity_name and add_session has the fields quantity as input
To use the feature create a goal with a quantity_name (pages remaning, flashcards done) and insert the quantity when adding new sessions
To create statistics like how many pages the user is reading every week the function list_sessions_between_dates can be used. The sessions also contain the quantity and to get a weekly count they can be filtered by goal id and the quantity can be summed.