Update mostly for clang-tidy in utils dir#20
Merged
Conversation
…with millisecond parameter in archon.cpp
…h and utilities.cpp
astronomerdave
approved these changes
Jul 31, 2024
prkrtg
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Replace calls to timout with float parameter with calls to sleep_for with millisecond parameter in archon.cpp * Clang-tidy updates in utilities.cpp and utilities.h * Clang-tidy updates in utilities.cpp and utilities.h * Separate declaration from function definition for rtrim in utilities.h and utilities.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First fixed call to timeout() with float value when function expects in value in archon.cpp
Then attempted to clear all clang-tidy warnings in utilities.cpp and utilities.h