Merged
Conversation
Contributor
mikelangmayr
commented
Aug 1, 2024
mikelangmayr
commented
- add test folder for unit tests
- create one unit test using Google Test library (gtest)
- add gtest executable to github workflow
scizen9
reviewed
Aug 1, 2024
Contributor
scizen9
left a comment
scizen9
left a comment
There was a problem hiding this comment.
Looks great! Glad to start down this path. Only one question: should we update the README to reflect the extra dependency for the tests?
Contributor
Author
|
@scizen9 I updated the README |
prkrtg
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Add first unit test using gtest * fixe typo in branch name * install gtest dependencies * clean up cmake file * add unit tests to github workflow * clean up * update README * README cleanup * add timezone local test * remove local timezone test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.