Merged
Conversation
…h, camerad.cpp, and generic.cpp
astronomerdave
approved these changes
Aug 14, 2024
Collaborator
astronomerdave
left a comment
astronomerdave
left a comment
There was a problem hiding this comment.
This looks fine.
As a side note, I have been replacing usleep with std::this_thread::sleep_for. usleep is deprecated (it's POSIX which is now obsolete). Besides being more up to date, sleep_for also has type safety. Not a big deal for this but just thought I'd mention it. At some point we might make a commit that changes only usleep.
…rrectly in archon.cpp
…ommands in hsetup function in archon.cpp
prkrtg
pushed a commit
that referenced
this pull request
Sep 8, 2025
* Initial try at adding power control to camerad in archon.cpp, archon.h, camerad.cpp, and generic.cpp * Added power_status property to Camera object in camera.h * Added get_status_key to archon.cpp * Added get_status_key to archon.h * Putting in all the steps for H2RG setup and sleeps in hsetup routine in archon.cpp * returning hsetup routine to just the setup command used before in archon.cpp * Added tested code for hsetup that will actually configure the chip correctly in archon.cpp * Update hsetup docstring in archon.cpp * Changing deprecated sleep commands with std::this_thread::sleep_for commands in hsetup function in archon.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added power control commands to control power to detector:
"power" - to get status of power
"power on" - to turn power on
"power off" - to turn power off