Skip to content

adopted c++ idiomatic practices#41

Merged
astronomerdave merged 2 commits intomainfrom
ctocpp
Aug 17, 2024
Merged

adopted c++ idiomatic practices#41
astronomerdave merged 2 commits intomainfrom
ctocpp

Conversation

@astronomerdave
Copy link
Copy Markdown
Collaborator

listener, socksend, and md5 were renamed .c to .cpp and this makes them idiomatic to c++

Comment thread utils/listener.cpp Outdated
// Changes:
// * Compiles for Linux
// * Takes the port and group on the command line
// * adopted c++ idiomataic practices
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idiomatic

Copy link
Copy Markdown
Contributor

@mikelangmayr mikelangmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Copy Markdown
Contributor

@scizen9 scizen9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge away.

@astronomerdave astronomerdave merged commit d538998 into main Aug 17, 2024
@astronomerdave astronomerdave deleted the ctocpp branch August 17, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants