Merged
Conversation
| bool modeselected; //!< true if a valid mode has been selected, false otherwise | ||
| bool firmwareloaded; //!< true if firmware is loaded, false otherwise | ||
| bool is_longexposure; //!< true for long exposure mode (exptime in sec), false for exptime in msec | ||
| bool longexposure_set; //!< true for long exposure mode (exptime in sec), false for exptime in msec |
Contributor
There was a problem hiding this comment.
having bools named is_... is a good convention, maybe it can be is_longexposure_set
| class ExposureTime { | ||
| private: | ||
| uint32_t _value; // exposure time in the current units | ||
| bool _set; // has it been set using the class value() function? |
prkrtg
pushed a commit
that referenced
this pull request
Sep 8, 2025
* fixes bug waiting for exposure and introduces ExposureTime class * renames Camera::ExposureTime bools to improve clarity --------- Co-authored-by: David Hale <dhale@milliways.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug waiting for exposure which was only evident with certain combinations of exposure times and longexpose state. Implements a Camera::ExposureTime class to avoid future ambiguities of exposure time and unit.