Skip to content

Landing AI service here#1

Merged
paopa merged 3 commits into
mainfrom
chore/migrate-ai-svc
Mar 13, 2024
Merged

Landing AI service here#1
paopa merged 3 commits into
mainfrom
chore/migrate-ai-svc

Conversation

@paopa
Copy link
Copy Markdown
Contributor

@paopa paopa commented Mar 13, 2024

As the title. migrate the project of AI service here.

@paopa paopa force-pushed the chore/migrate-ai-svc branch 2 times, most recently from a1541fa to ece5bcc Compare March 13, 2024 08:03
@paopa paopa force-pushed the chore/migrate-ai-svc branch from ece5bcc to 7e1cb23 Compare March 13, 2024 08:18
@paopa paopa requested a review from cyyeh March 13, 2024 08:20
@paopa paopa changed the title Migrate the AI service to the new repo Landing AI service here Mar 13, 2024
Comment thread wren-ai-service/README.md Outdated
Copy link
Copy Markdown
Member

@cyyeh cyyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paopa paopa force-pushed the chore/migrate-ai-svc branch from caa90d2 to 39cfe63 Compare March 13, 2024 08:47
@paopa paopa merged commit 98e6d92 into main Mar 13, 2024
@paopa paopa deleted the chore/migrate-ai-svc branch March 13, 2024 08:56
@paopa paopa added the module/ai-service ai-service related label Mar 13, 2024
chilijung pushed a commit that referenced this pull request Oct 13, 2024
seancoding-day pushed a commit to Zoewry/WrenAI that referenced this pull request Jul 31, 2025
…s-1753842262630

Add Claude Code GitHub Workflow
PaulChen79 added a commit that referenced this pull request May 8, 2026
The previous resolver only consulted cwd when --mdl was absent, so
`--mdl <base64>` or `--mdl /external.json` from inside a pinned project
silently bypassed the pin and fell back to global active — exactly the
silent-mismatch class this PR set out to close, just triggered by --mdl
shape instead of by a stale active.

- Extract _discover_project_for_engine() so --mdl becomes a pure MDL
  artifact override; project context is determined by walking up from
  the MDL path AND from cwd, in that order.
- Walk up directory tree from --mdl rather than hard-coding parent.parent
  — <project>/target/mdl.json is a build default, not a contract.
- Active profile fires only when neither discovery finds a project.

Addresses goldmedal review #1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/ai-service ai-service related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants