Skip to content

chore(wren-ai-service): refine intent classification for time related questions#1067

Merged
paopa merged 2 commits into
mainfrom
chore/ai-service/improve-ai-service
Dec 26, 2024
Merged

chore(wren-ai-service): refine intent classification for time related questions#1067
paopa merged 2 commits into
mainfrom
chore/ai-service/improve-ai-service

Conversation

@cyyeh
Copy link
Copy Markdown
Member

@cyyeh cyyeh commented Dec 26, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced intent classification to explicitly handle time/date formats in user queries.
  • Bug Fixes
    • Improved guidance for rephrasing user questions related to temporal aspects.

@cyyeh cyyeh added module/ai-service ai-service related ci/ai-service ai-service related labels Dec 26, 2024
@cyyeh cyyeh requested a review from paopa December 26, 2024 08:01
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 26, 2024

Walkthrough

The pull request introduces a modification to the intent classification system prompt in the Wren AI service. The change focuses on enhancing the prompt's instructions by adding a specific guideline for handling time and date-related queries. The new instruction directs the system to include time/date formats (such as YYYY-MM-DD) when rephrasing user questions that involve temporal information, thereby improving the clarity and precision of query processing.

Changes

File Change Summary
wren-ai-service/src/pipelines/generation/intent_classification.py Updated system prompt to include explicit instructions for handling time/date formats in user queries

Poem

🕰️ A Rabbit's Temporal Tale 🐰

In prompts of code, a whisker's might,
Time and dates now shine so bright
YYYY-MM-DD takes the stage
Clarity leaps from every page
A temporal dance of logic clear

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
wren-ai-service/src/pipelines/generation/intent_classification.py (1)

34-34: Consider providing more detailed date/time formats for broader coverage.

Currently, the step references “YYYY-MM-DD” specifically. Providing additional examples (e.g., “MM/DD/YYYY,” “YYYY-MM-DD HH:MM”) would help address a wider variety of time/date queries.

-    - Third, if the user's question is related to time/date, add time/date format(such as YYYY-MM-DD) in the rephrased_question output.
+    - Third, if the user's question is related to time/date, add one or more time/date formats (e.g., YYYY-MM-DD, MM/DD/YYYY, or YYYY-MM-DD HH:MM) in the rephrased_question output.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e25b4c and 0b5a718.

📒 Files selected for processing (1)
  • wren-ai-service/src/pipelines/generation/intent_classification.py (1 hunks)

@paopa paopa merged commit 67603ca into main Dec 26, 2024
@paopa paopa deleted the chore/ai-service/improve-ai-service branch December 26, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/ai-service ai-service related module/ai-service ai-service related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants