Skip to content

chore(wren-ai-service): fix followup ask#1256

Merged
paopa merged 2 commits into
mainfrom
chore/ai-service/update-followup
Feb 4, 2025
Merged

chore(wren-ai-service): fix followup ask#1256
paopa merged 2 commits into
mainfrom
chore/ai-service/update-followup

Conversation

@cyyeh
Copy link
Copy Markdown
Member

@cyyeh cyyeh commented Feb 4, 2025

Summary by CodeRabbit

  • New Features

    • The system now leverages users’ historical SQL statements rather than previous queries, enhancing the relevance of generated responses.
  • Refactor

    • Streamlined the handling of historical input data to align with the updated focus on SQL inputs.

@cyyeh cyyeh added module/ai-service ai-service related ci/ai-service ai-service related labels Feb 4, 2025
@cyyeh cyyeh requested a review from paopa February 4, 2025 03:01
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 4, 2025

Walkthrough

The changes update the intent classification process to focus on SQL queries instead of natural language questions. The placeholder in the user prompt template was renamed from "User's previous questions" to "User's previous SQLs." The prompt function now retrieves history using history.sql (or defaults to an empty list), and its signature has been updated to include a default configuration. These modifications affect how user history is processed and integrated into the prompt generation.

Changes

File Change Summary
wren-ai-service/.../intent_classification.py Renamed placeholder to "User's previous SQLs"; updated prompt to use history.sql for query history; modified function signature to set default configuration

Sequence Diagram(s)

sequenceDiagram
    participant UI as User Interface
    participant IC as IntentClassification
    participant PB as PromptBuilder
    participant H as History (Optional)

    UI->>IC: Call prompt(query, schema, prompt_builder, history, configuration)
    alt History provided
        IC->>H: Retrieve history.sql
    else No history
        IC->>IC: Use empty SQL list
    end
    IC->>PB: Pass query and SQL history to prompt_builder.run
    PB-->>IC: Return generated prompt
    IC-->>UI: Return prompt output
Loading

Possibly related PRs

  • chore(wren-ai-service): minor update #1213: The changes in the main PR are related to the modifications in the prompt function's signature and handling of the configuration parameter, which aligns with similar updates in the retrieved PR's prompt function.
  • chore(wren-ai-service): fix intent classification #1074: The changes in the main PR are related to the modifications in the prompt function, which is also updated in the retrieved PR, indicating a direct connection in their implementations.

Suggested reviewers

  • paopa

Poem

Oh, in the code garden I hop with glee,
SQL carrots replacing old news, you see!
The prompt now dances on a fresher beat,
With history SQL making it neat.
From bunny hops to clever code we sing,
Celebrating change with every joyful spring!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b83d35b and 19b8935.

📒 Files selected for processing (1)
  • wren-ai-service/src/pipelines/generation/intent_classification.py (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • wren-ai-service/src/pipelines/generation/intent_classification.py
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: pytest
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@paopa paopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/ai-service ai-service related module/ai-service ai-service related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants