chore(wren-ai-service): fix config examples#1267
Conversation
WalkthroughThis pull request updates configuration files for the AI service. In two files, the embedder model configuration formatting is modified by removing the list item marker, while preserving the model name, API base, and timeout settings. In the Google AI Studio configuration, the embedder reference is consistently updated from the previous model to a new gemini-based model across various pipeline entries. The overall configuration structure and comments remain intact. Changes
Suggested labels
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
wren-ai-service/docs/config_examples/config.google_ai_studio.yaml (1)
110-113: Remove Trailing Whitespace
Line 112 contains trailing whitespace after the embedder value (litellm_embedder.gemini/text-embedding-004). Removing the extra space will help avoid potential YAML parsing issues.Suggested diff:
- embedder: litellm_embedder.gemini/text-embedding-004 + embedder: litellm_embedder.gemini/text-embedding-004🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 112-112: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
wren-ai-service/docs/config_examples/config.deepseek.yaml(1 hunks)wren-ai-service/docs/config_examples/config.google_ai_studio.yaml(4 hunks)wren-ai-service/docs/config_examples/config.groq.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
wren-ai-service/docs/config_examples/config.google_ai_studio.yaml
[error] 112-112: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (7)
wren-ai-service/docs/config_examples/config.google_ai_studio.yaml (3)
18-22: Embedder Configuration Updated for Gemini Model
The embedder section now specifies thegemini/text-embedding-004model with its dedicated API base and timeout. This update helps standardize the configuration according to the new gemini-based approach.
92-93: Pipeline Embedder Reference Consistency
The pipeline entry forquestion_recommendation_db_schema_retrievalnow correctly referenceslitellm_embedder.gemini/text-embedding-004. This aligns with the updated embedder naming convention and ensures consistency across pipeline tasks.
102-105: Updated Pipeline for Intent Classification
The updated pipeline entry forintent_classificationnow includes the correct embedder reference (litellm_embedder.gemini/text-embedding-004) alongside the LLM. This change is consistent with the overall configuration update.wren-ai-service/docs/config_examples/config.groq.yaml (1)
18-22: Simplified Embedder Model Entry Formatting
The embedder configuration now omits the list item dash (i.e. “-”) for the sole model entry. This cleaner format is appropriate when only one embedder model is being configured and improves readability.wren-ai-service/docs/config_examples/config.deepseek.yaml (3)
9-30: LLM Models Configuration Verification
The LLM section correctly lists multiple Deepseek models (reasoner, chat, coder) with consistent API base settings and kwargs. No issues were detected here.
35-40: Embedder Model Entry Formatting Updated
The embedder model entry has been reformatted by removing the dash (list marker) from the beginning. This results in a tidier YAML structure when a single embedder configuration is expected, while keeping theapi_baseandtimeoutsettings intact.
55-142: Pipeline Section Consistency Check
The pipeline entries remain unchanged and continue referencing the appropriate LLM and embedder configurations. They align with the intended configuration structure and should integrate smoothly with the overall system settings.🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 60-60: wrong indentation: expected 0 but found 2
(indentation)
[error] 130-130: trailing spaces
(trailing-spaces)
2 participants
Summary by CodeRabbit
Documentation
Refactor