fix(wren-ui): fix language for generate question for SQL pairs

[fredalai]

Description

• Correct the language configuration in SqlPairService to use WrenAILanguage[project.language]
• Correct configurations parameter name for post /v1/sql-questions API

UI (manual testing)

Summary by CodeRabbit

• Bug Fixes
  • Improved the configuration of automated question generation to ensure it reliably meets external expectations.
  • Enhanced language validation so that only supported language options are applied, ensuring smoother performance across projects.

[coderabbitai]

Walkthrough

This pull request updates the API request construction for generating questions across two services. In the WrenAIAdaptor class, the property name within the request object is updated from configuration to configurations. In the SqlPairService class, the assignment of the language property is modified to utilize the WrenAILanguage enum, ensuring valid language configuration.

Changes

File Path(s)	Change Summary
wren-ui/src/apollo/server/adaptors/wrenAIAdaptor.ts	Renamed the property configuration to configurations in the generateQuestions method.
wren-ui/src/apollo/server/services/sqlPairService.ts	Updated the assignment of language using the WrenAILanguage enum in the configurations object; added a new import for WrenAILanguage.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WrenAIAdaptor
    participant API_Server

    Client->>WrenAIAdaptor: Call generateQuestions(request)
    WrenAIAdaptor->>WrenAIAdaptor: Build request payload with `configurations`
    WrenAIAdaptor->>API_Server: Send payload to API endpoint
    API_Server-->>WrenAIAdaptor: Response
    WrenAIAdaptor-->>Client: Return generated questions

Loading

sequenceDiagram
    participant Client
    participant SqlPairService
    participant EnumChecker

    Client->>SqlPairService: Call generateQuestions(project)
    SqlPairService->>EnumChecker: Validate project.language against WrenAILanguage enum
    alt Valid Language
        EnumChecker-->>SqlPairService: Return valid language
    else Invalid Language
        EnumChecker-->>SqlPairService: Return default `WrenAILanguage.EN`
    end
    SqlPairService->>SqlPairService: Build request payload with updated language in configurations
    SqlPairService-->>Client: Return generated questions

Loading

Possibly related PRs

• fix(wren-ui): add lang for adjust chart api #1061: Modifications involving the configurations property within the WrenAIAdaptor class.
• chore(wren-ai-service): Add Bird dataset support and enhance configuration documentation #1427: Updates to the configurations object in the generateQuestions method, aligning with these changes.
• chore(wren-ai-service): minor updates #1326: Similar adjustments in the generateQuestions methods across services focus on modifications to the configurations structure.

Suggested labels

module/ui, module/ai-service

Suggested reviewers

• andreashimin
• wwwy3y3

Poem

Hoppin’ through the code so light,
I found new keys shining bright.
With configurations now in play,
And enum checks to guide my way.
A merry rabbit cheers this night! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0bfe2b and 5e52f9c.

📒 Files selected for processing (2)

• wren-ui/src/apollo/server/adaptors/wrenAIAdaptor.ts (1 hunks)
• wren-ui/src/apollo/server/services/sqlPairService.ts (2 hunks)

🔇 Additional comments (3)

wren-ui/src/apollo/server/adaptors/wrenAIAdaptor.ts (1)

514-514: Property name change ensures correct API contract

The property name change from configuration to configurations aligns with the endpoint expectations at /v1/sql-questions and maintains consistency with other methods in this class that also use the plural form (like createTextBasedAnswer).

wren-ui/src/apollo/server/services/sqlPairService.ts (2)

7-7: Correctly importing WrenAILanguage enum

Adding the import for WrenAILanguage is necessary to support the language configuration enhancement.

---

64-64: Improved language configuration with fallback

This change enhances robustness by:

1. Using the WrenAILanguage enum to ensure only valid language values are used
2. Providing a fallback to English if the project language is not found in the enum

This fix properly addresses the PR objective to "fix language for generate question for SQL pairs".

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.