chore(wren-ai-service): minor updates (ai-env-changed)#1549
Conversation
WalkthroughThis update revises prompt instructions and internal documentation across several SQL generation and reasoning pipeline modules. It introduces stricter adherence to provided INSTRUCTIONS sections, clarifies references to SQL SAMPLES, and adds a GENERAL RULES section to the SQL prompt. The SQL rules now include explicit guidance on converting date/time columns stored as numeric types to TIMESTAMP using appropriate functions. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Pipeline
participant PromptEngine
participant SqlFunctionUtil
User->>Pipeline: Submit SQL generation request with INSTRUCTIONS, SAMPLES, etc.
Pipeline->>PromptEngine: Build prompt with GENERAL RULES and SQL RULES
PromptEngine->>Pipeline: Return constructed prompt
Pipeline->>SqlFunctionUtil: Retrieve and filter SQL functions
SqlFunctionUtil->>Pipeline: Return valid SQL function metadata
Pipeline->>User: Return generated SQL and reasoning
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
deployment/kustomizations/base/cm.yaml(1 hunks)docker/config.example.yaml(1 hunks)wren-ai-service/tools/config/config.example.yaml(1 hunks)wren-ai-service/tools/config/config.full.yaml(1 hunks)wren-launcher/commands/launch.go(2 hunks)wren-launcher/utils/docker.go(2 hunks)
✅ Files skipped from review due to trivial changes (3)
- wren-ai-service/tools/config/config.example.yaml
- docker/config.example.yaml
- wren-ai-service/tools/config/config.full.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pytest
🔇 Additional comments (3)
wren-launcher/utils/docker.go (1)
33-40: New GPT-4.1 model series added to model mapping.The code adds three new GPT-4.1 series models to the
generationModelToModelNamemap, expanding the available model options. This is a good addition that keeps the system up-to-date with newer OpenAI models.wren-launcher/commands/launch.go (2)
109-112: New GPT-4.1 models added to user selection options.The prompt selection options have been expanded to include the newer GPT-4.1 series models (nano, mini, and standard), providing users with more choices. This aligns well with the model mapping changes in docker.go.
302-309: Added validation for new GPT-4.1 models.The validation map has been appropriately updated to include the new GPT-4.1 series models, ensuring consistency with the UI selection options. There's also a minor formatting adjustment for the existing model entries with their indentation.
Summary by CodeRabbit