fix(ci): allow same-version npm bump in wasm publish workflows#2243
Conversation
release-please updates package.json's version when its release PR is merged, so by the time the publish workflow runs on main the version already matches the release tag and 'npm version 0.2.0' fails with 'Version not changed'. Pass --allow-same-version so the bump is a no-op when versions already match. Apply to both the OIDC (release-please) and token-based (RC) pipelines to keep them in sync.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughWorkflows that set package.json version for wren-core-wasm now pass ChangesPublish Workflow Changes
Release-Please Manifest Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The 0.2.0 publish to npm never landed (the npm version step failed — fixed in this PR), but release-please had already bumped the manifest on PR merge. npm latest is still 0.1.0, so reset the manifest to match reality. release-please will re-propose the 0.1.0 → 0.2.0 bump on the next push to main.
Summary
The release-please-driven stable publish failed at the Set version in package.json step:
```
VERSION: 0.2.0
npm error Version not changed
```
release-please-actionbumpspackage.jsonas part of the release PR. Once that PR merges intomain, thepackage.jsonversion onmainalready matches the released tag, sonpm version 0.2.0errors out with "Version not changed".Fix
Pass
--allow-same-versionso the bump is a no-op when the version already matches. Apply to both wasm publish workflows:publish-wren-core-wasm.yml(OIDC, release-please) — directly fixes the failing path.publish-wren-core-wasm-rc.yml(token, RC) — RC won't normally hit this since-rc.Nversions always differ frommain, but mirrors the change to keep the two pipelines in sync.Test plan
Set version in package.jsonsucceeds andnpm publishfollows.🤖 Generated with Claude Code
Summary by CodeRabbit