test(wren-pydantic): stop hardcoding version in smoke test#2267
Conversation
The smoke test asserted `__version__ == "0.1.0"`, which broke every release-please PR that bumped the version (e.g. #2261 failed on py3.11/py3.12 after the 0.2.0 bump). Replace it with a type/non-empty check so the smoke test verifies importability without coupling to a specific release number. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe smoke test for wren_pydantic is updated to validate that ChangesSmoke Test Version Validation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
assert wren_pydantic.__version__ == "0.1.0"intests/test_smoke.pywith a type/non-empty check.tests (py3.11)andtests (py3.12)both failed because__version__was already updated to0.2.0by release-please but the test still expected0.1.0).Why this assertion shape
The smoke test's job is to verify the package imports and exposes a version string. The exact value is enforced in
.github/workflows/publish-wren-pydantic.yml(regex\d+\.\d+\.\d+(rc\d+)?during the build step), so the test doesn't need to duplicate that check.Test plan
tests (py3.11)passestests (py3.12)passes🤖 Generated with Claude Code
Summary by CodeRabbit